Rename build files from TARGETS to BUCK (group ID: -3631139791766519999) (#19429) - #19429
Rename build files from TARGETS to BUCK (group ID: -3631139791766519999) (#19429)#19429bigfootjon wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414855. |
This PR needs a
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19429
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b3abd73 with merge base 4413a5c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates select Buck build definitions as part of renaming/migrating from TARGETS to BUCK, updating targets to use the build-file migration wrappers.
Changes:
- Removed
TARGETSfiles and added correspondingBUCKfiles for selected test directories. - Wrapped target declarations with
fbcode_target/non_fbcode_targetmigration macros. - Updated a CUDA runtime
nvcc_flags.bzlload path.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| backends/cuda/runtime/shims/tests/TARGETS | Removed legacy TARGETS file content. |
| backends/cuda/runtime/shims/tests/BUCK | Added BUCK file using migration wrappers to invoke common target definitions. |
| backends/cuda/runtime/TARGETS | Converted runtime.* targets to fbcode_target wrappers; updated nvcc flags load path. |
| backends/cuda/TARGETS | Converted Python targets to fbcode_target wrappers. |
| backends/cortex_m/test/TARGETS | Removed legacy TARGETS with a python unittest and common targets. |
| backends/cortex_m/test/BUCK | Added merged BUCK file containing migration wrappers + the prior unittest definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| oncall("executorch") | ||
|
|
||
| fbcode_target(_kind = define_common_targets,) |
| load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest") | ||
| load("targets.bzl", "define_common_targets") | ||
|
|
||
| fbcode_target(_kind = python_unittest, | ||
| name="test_replace_quant_nodes", | ||
| srcs=[ | ||
| "test_helpers_passes_utils.py", | ||
| "test_replace_quant_nodes.py", | ||
| ], | ||
| deps=[ | ||
| "//pytorch/ao:torchao", # @manual | ||
| "//caffe2:torch", | ||
| "//executorch/backends/cortex_m/passes:replace_quant_nodes_pass", | ||
| "//executorch/backends/cortex_m/ops:ops", | ||
| ], | ||
| ) |
| # !!!! fbcode/executorch/backends/cortex_m/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! | ||
|
|
||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest") | ||
| load("targets.bzl", "define_common_targets") |
meta-codesync
Bot
changed the title
f2f9248 to
b3abd73
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary: Pull Request resolved: #19429
Reviewed By: bigfootjon
Differential Revision: D104414855